From 9624304bd42a5a67a33c4d7c6b456b5dd8924ed4 Mon Sep 17 00:00:00 2001 From: "Gan, Jimmy" Date: Tue, 26 May 2026 00:09:53 +0800 Subject: [PATCH] fix: remove stale containers unconditionally before compose Old nas-dashboard from failed runs was still running, causing the retry path to skip (old container detected as running). Also stale docker-socket-proxy with restart:unless-stopped caused compose conflict. Fix by force-removing both before compose. Co-Authored-By: Claude Opus 4.7 --- .gitea/workflows/deploy.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitea/workflows/deploy.yml b/.gitea/workflows/deploy.yml index 5b6b235..20ca716 100644 --- a/.gitea/workflows/deploy.yml +++ b/.gitea/workflows/deploy.yml @@ -251,7 +251,8 @@ jobs: # Stop and remove old containers to force recreate with new image. # External networks (gitea_gitea, nas-dashboard_internal) are preserved. docker compose -f /nas-dashboard/docker-compose.yml down 2>/dev/null || true - echo "Old containers stopped" + docker rm -f docker-socket-proxy nas-dashboard 2>/dev/null || true + echo "Old containers stopped and removed" # --pull never prevents overwriting the image we just built docker compose -f /nas-dashboard/docker-compose.yml up -d --pull never 2>&1 || true