jimmy/nas-tools
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix: stop old containers before compose up in production deploy

Browse Source 
- Add docker compose down step before up to ensure the production
  container is recreated with the freshly-built image
- Without this, compose sees the old running container and skips it,
  while the Docker 24 network bug is silently swallowed by || true

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Gan, Jimmy
2026-05-18 00:07:17 +08:00
parent d5faa14d07
commit 9811b7023d
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.gitea/workflows/deploy.yml
+5
View File
@@ -244,6 +244,11 @@ jobs:
set -e set -e
export DOCKER_API_VERSION=1.43 export DOCKER_API_VERSION=1.43
# Stop and remove old containers to force recreate with new image.
# External networks (gitea_gitea, nas-dashboard_internal) are preserved.
docker compose -f /nas-dashboard/docker-compose.yml down 2>/dev/null || true
echo "Old containers stopped"
# Docker 24 compose fails when it can't connect external networks # Docker 24 compose fails when it can't connect external networks
# during container creation. Try compose first; if the container # during container creation. Try compose first; if the container
# isn't created, strip networks from compose file and retry. # isn't created, strip networks from compose file and retry.