fix: open dev port to all interfaces and run smoke tests via docker exec

- Change port binding from 127.0.0.1:4001:4000 to 4001:4000 so CI containers can reach the dashboard from any network namespace - Run smoke tests via docker exec against localhost:4000 instead of curling the external hostname, which resolves to the Caddy VPS and times out Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-17 20:53:26 +08:00
parent cf1de9c631
commit deb049c889
2 changed files with 39 additions and 8 deletions
@@ -294,10 +294,41 @@ jobs:

      - name: Run smoke tests
        run: |
-          bash scripts/smoke-test-dashboard.sh dev
-          if [ $? -ne 0 ]; then
-            echo "❌ Smoke tests failed! Check logs above."
-            docker logs nas-dashboard-dev --tail 100
-            exit 1
-          fi
-          echo "✅ Smoke tests passed"
+          echo "=== Running smoke tests via docker exec ==="
+
+          # Test 1: Health check
+          echo "1. Testing health endpoint..."
+          docker exec nas-dashboard-dev python3 -c "import urllib.request,json; d=json.loads(urllib.request.urlopen('http://localhost:4000/api/health',timeout=5).read()); assert d['status']=='ok', f'unexpected: {d}'" && echo "✅ Health check passed" || { echo "❌ Health check failed"; docker logs nas-dashboard-dev --tail 50; exit 1; }
+
+          # Test 2: Frontend loads
+          echo "2. Testing frontend loads..."
+          docker exec nas-dashboard-dev python3 -c "import urllib.request; html=urllib.request.urlopen('http://localhost:4000/',timeout=5).read().decode(); assert 'NAS Dashboard' in html, f'missing NAS Dashboard'" && echo "✅ Frontend loads" || { echo "❌ Frontend failed to load"; exit 1; }
+
+          # Test 3: API endpoints require auth
+          echo "3. Testing API endpoints require auth..."
+          docker exec nas-dashboard-dev python3 -c "
+          import urllib.request, json
+          try:
+              resp = urllib.request.urlopen('http://localhost:4000/api/conversations/dates', timeout=5)
+              data = resp.read().decode()
+              assert 'Not authenticated' in data or 'detail' in data, f'unexpected: {data[:200]}'
+          except urllib.error.HTTPError as e:
+              assert e.code in (401, 403), f'expected 401/403, got {e.code}'
+          " && echo "✅ API requires auth" || { echo "❌ Auth check failed"; exit 1; }
+
+          # Test 4: Double /api/ prefix bug (non-failing)
+          echo "4. Testing for double /api/ prefix bug..."
+          docker exec nas-dashboard-dev python3 -c "
+          import urllib.request
+          try:
+              urllib.request.urlopen('http://localhost:4000/api/api/conversations/dates', timeout=5)
+              print('WARNING: /api/api/ returned 200')
+          except urllib.error.HTTPError as e:
+              assert e.code == 404, f'expected 404, got {e.code}'
+              print('OK: /api/api/ returned 404')
+          " && echo "✅ No double /api/ prefix bug" || echo "⚠️  Double API prefix warning"
+
+          # Test 5: Container health already verified in previous step
+
+          echo ""
+          echo "=== All smoke tests passed! ==="