jimmy/nas-tools
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(tests): remove Docker tests + RBAC fixtures (routes removed)
Deploy Dashboard (Dev) / Backend Tests (push) Failing after 1m6s
Details
Deploy Dashboard (Dev) / Build Dev Image (push) Has been skipped
Details
Deploy Dashboard (Dev) / Frontend Tests (push) Successful in 52s
Details
Deploy Dashboard (Dev) / Deploy to Dev (push) Has been skipped
Details

Browse Source
This commit is contained in:
Gan, Jimmy
2026-07-09 23:36:39 +08:00
parent 1646af914f
commit e66dc9a38a
2 changed files with 3 additions and 161 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dashboard/backend/tests/conftest.py
+3 -3
View File
@@ -71,7 +71,7 @@ def temp_rbac_file(temp_volume_root):
data = { data = {
"role_defaults": { "role_defaults": {
"admin": {"pages": "*", "sidebar_links": "*"}, "admin": {"pages": "*", "sidebar_links": "*"},
"member": {"pages": ["dashboard", "docker"], "sidebar_links": "*"}, "member": {"pages": ["dashboard"], "sidebar_links": "*"},
"viewer": {"pages": ["dashboard"], "sidebar_links": ["dashboard"]}, "viewer": {"pages": ["dashboard"], "sidebar_links": ["dashboard"]},
}, },
"user_overrides": {}, "user_overrides": {},
@@ -470,11 +470,11 @@ def mock_rbac_data():
return { return {
"role_defaults": { "role_defaults": {
"admin": {"pages": "*", "sidebar_links": "*"}, "admin": {"pages": "*", "sidebar_links": "*"},
"member": {"pages": ["dashboard", "docker", "files"], "sidebar_links": "*"}, "member": {"pages": ["dashboard", "files"], "sidebar_links": "*"},
"viewer": {"pages": ["dashboard"], "sidebar_links": ["dashboard"]}, "viewer": {"pages": ["dashboard"], "sidebar_links": ["dashboard"]},
}, },
"user_overrides": { "user_overrides": {
"customuser": {"pages": ["dashboard", "docker"], "sidebar_links": ["dashboard", "docker", "files"]} "customuser": {"pages": ["dashboard"], "sidebar_links": ["dashboard", "files"]}
}, },
} }
dashboard/backend/tests/integration/test_docker.py
-158
View File
@@ -1,158 +0,0 @@
"""
Integration tests for Docker operations.
"""
import pytest
class TestDockerContainerList:
"""Test listing Docker containers."""
def test_list_containers_success(self, test_app, admin_headers):
"""Test listing containers successfully."""
response = test_app.get("/api/docker/containers", headers=admin_headers)
assert response.status_code == 200
data = response.json()
assert isinstance(data, list)
if len(data) > 0:
container = data[0]
assert "id" in container
assert "name" in container
assert "status" in container
def test_list_containers_without_auth(self, test_app):
"""Test listing containers without authentication."""
response = test_app.get("/api/docker/containers")
assert response.status_code == 401
class TestDockerContainerActions:
"""Test Docker container start/stop/restart actions."""
def test_start_container_success(self, test_app, admin_headers, mock_docker_client):
"""Test starting a container."""
container_id = "abc123"
response = test_app.post(f"/api/docker/containers/{container_id}/start", headers=admin_headers)
assert response.status_code == 200
data = response.json()
assert data["ok"] is True
def test_stop_container_success(self, test_app, admin_headers, mock_docker_client):
"""Test stopping a container."""
container_id = "abc123"
response = test_app.post(f"/api/docker/containers/{container_id}/stop", headers=admin_headers)
assert response.status_code == 200
def test_restart_container_success(self, test_app, admin_headers, mock_docker_client):
"""Test restarting a container."""
container_id = "abc123"
response = test_app.post(f"/api/docker/containers/{container_id}/restart", headers=admin_headers)
assert response.status_code == 200
def test_container_action_without_auth(self, test_app):
"""Test container action without authentication."""
response = test_app.post("/api/docker/containers/abc123/start")
assert response.status_code == 401
def test_container_action_invalid_action(self, test_app, admin_headers):
"""Test container action with invalid action."""
response = test_app.post("/api/docker/containers/abc123/invalid_action", headers=admin_headers)
assert response.status_code == 400
data = response.json()
assert "detail" in data
class TestDockerContainerLogs:
"""Test Docker container logs retrieval."""
def test_get_container_logs_success(self, test_app, admin_headers, mock_docker_client):
"""Test getting container logs."""
container_id = "abc123"
response = test_app.get(f"/api/docker/containers/{container_id}/logs", headers=admin_headers)
assert response.status_code == 200
data = response.json()
assert "logs" in data or isinstance(data, str)
def test_get_container_logs_with_tail(self, test_app, admin_headers, mock_docker_client):
"""Test getting container logs with tail limit."""
container_id = "abc123"
response = test_app.get(f"/api/docker/containers/{container_id}/logs?tail=100", headers=admin_headers)
assert response.status_code == 200
def test_get_container_logs_without_auth(self, test_app):
"""Test getting logs without authentication."""
response = test_app.get("/api/docker/containers/abc123/logs")
assert response.status_code == 401
def test_get_container_logs_nonexistent(self, test_app, admin_headers, mock_docker_client):
"""Test getting logs for nonexistent container."""
# Note: In this test setup, the mock always returns a container
# Testing actual error handling would require a different approach
# For now, verify the endpoint works with the mock
response = test_app.get("/api/docker/containers/nonexistent/logs", headers=admin_headers)
# With the current mock setup, this will succeed
assert response.status_code == 200
class TestDockerPermissions:
"""Test Docker operation permissions."""
@pytest.fixture
def member_token(self, mock_config, temp_auth_file, temp_rbac_file):
"""Create token for member role."""
from datetime import timedelta
from auth_service import create_access_token
return create_access_token(data={"sub": "memberuser", "role": "member"}, expires_delta=timedelta(minutes=30))
@pytest.fixture
def member_headers(self, member_token):
"""Headers with member access token."""
return {"Authorization": f"Bearer {member_token}"}
def test_member_can_list_containers(self, test_app, member_headers):
"""Test that member can list containers."""
response = test_app.get("/api/docker/containers", headers=member_headers)
# Members should be able to view containers
assert response.status_code == 200
def test_member_cannot_start_container(self, test_app, member_headers):
"""Test that member cannot start containers (admin only)."""
response = test_app.post("/api/docker/containers/abc123/start", headers=member_headers)
# Should be forbidden for non-admin
assert response.status_code == 403
def test_viewer_can_list_containers(self, test_app, mock_config, temp_auth_file, temp_rbac_file):
"""Test that viewer can list containers if they have docker page access."""
from datetime import timedelta
from auth_service import create_access_token
viewer_token = create_access_token(
data={"sub": "vieweruser", "role": "viewer"}, expires_delta=timedelta(minutes=30)
)
headers = {"Authorization": f"Bearer {viewer_token}"}
response = test_app.get("/api/docker/containers", headers=headers)
# Viewer may not have docker page access by default
assert response.status_code in [200, 403]