8 Commits

Author SHA1 Message Date
Gan, Jimmy b5b6f9134b fix: use native navigation for file downloads to support large files
Run Tests / Backend Tests (pull_request) Failing after 4m45s
Run Tests / Frontend Tests (pull_request) Failing after 1m20s
Deploy Dashboard (Dev) / deploy-dev (push) Failing after 2m47s
Run Tests / Backend Tests (push) Failing after 5m52s
Run Tests / Frontend Tests (push) Failing after 1m43s
Run Tests / Test Summary (pull_request) Failing after 33s
Run Tests / Test Summary (push) Has been cancelled
2026-04-18 23:57:07 +08:00
jimmy d260f8159a Merge pull request 'Fix streaming downloads for large files' (#51) from fix/streaming-downloads into main
Deploy Dashboard / deploy (push) Failing after 16m43s
Run Tests / Backend Tests (push) Failing after 4m42s
Run Tests / Test Summary (push) Failing after 17s
Run Tests / Frontend Tests (push) Failing after 2m39s
2026-04-18 12:03:26 +08:00
Gan, Jimmy 88e53f3f8e fix: implement streaming downloads for large files
Run Tests / Backend Tests (pull_request) Failing after 5m29s
Run Tests / Frontend Tests (pull_request) Failing after 3m55s
Run Tests / Test Summary (pull_request) Failing after 18s
- Add token-based download system with 5-minute expiry
- Stream files in 8MB chunks on backend (no memory loading)
- Use browser native download with tokens on frontend
- Fixes hang on large files (10GB+) by avoiding memory buffering
2026-04-18 11:03:22 +08:00
jimmy 45a7ce3ece Merge pull request 'Fix file download filename' (#50) from fix/file-download-filename into main
Deploy Dashboard / deploy (push) Failing after 3m44s
Run Tests / Backend Tests (push) Failing after 4m39s
Run Tests / Frontend Tests (push) Failing after 36s
Run Tests / Test Summary (push) Failing after 12s
2026-04-17 14:18:05 +08:00
Gan, Jimmy 1ee244ee39 fix: set filename in file download response
Run Tests / Backend Tests (pull_request) Failing after 5m23s
Run Tests / Frontend Tests (pull_request) Failing after 34s
Run Tests / Test Summary (pull_request) Failing after 15s
2026-04-17 14:17:33 +08:00
jimmy a807ec00af Merge pull request 'Fix file download error handling' (#49) from fix/file-download-error-handling into main
Deploy Dashboard / deploy (push) Failing after 4m34s
Run Tests / Backend Tests (push) Failing after 4m19s
Run Tests / Frontend Tests (push) Failing after 1m18s
Run Tests / Test Summary (push) Failing after 16s
2026-04-13 10:27:50 +08:00
Gan, Jimmy cdf8ab18fc fix: add error handling and feedback for file downloads
Run Tests / Backend Tests (pull_request) Failing after 5m4s
Run Tests / Frontend Tests (pull_request) Failing after 1m5s
Run Tests / Test Summary (pull_request) Failing after 17s
2026-04-13 10:25:40 +08:00
jimmy 1c3cbd187b Merge pull request 'Fix batch processing for large conversation files' (#48) from fix/batch-processing into main
Run Tests / Backend Tests (push) Failing after 4m18s
Run Tests / Frontend Tests (push) Failing after 3m14s
Run Tests / Test Summary (push) Failing after 18s
2026-04-12 11:49:30 +08:00
3 changed files with 114 additions and 21 deletions
+63 -5
View File
@@ -1,11 +1,13 @@
import logging import logging
import os import os
import re import re
import secrets
import shutil import shutil
import time
from pathlib import Path from pathlib import Path
from fastapi import APIRouter, Depends, File, HTTPException, UploadFile from fastapi import APIRouter, Depends, File, HTTPException, UploadFile, Query
from fastapi.responses import FileResponse from fastapi.responses import StreamingResponse
from config import VOLUME_ROOT from config import VOLUME_ROOT
from rbac import require_admin from rbac import require_admin
@@ -17,6 +19,10 @@ BASE = Path(VOLUME_ROOT)
MAX_UPLOAD_SIZE = 100 * 1024 * 1024 # 100 MB MAX_UPLOAD_SIZE = 100 * 1024 * 1024 # 100 MB
BLOCKED_DIRS = {"@appstore", "@docker", "@eaDir", "@S2S", "@sharesnap", "@tmp", "docker", "homes", "backups"} BLOCKED_DIRS = {"@appstore", "@docker", "@eaDir", "@S2S", "@sharesnap", "@tmp", "docker", "homes", "backups"}
# Download token storage: {token: (path, expiry_timestamp)}
_download_tokens = {}
TOKEN_EXPIRY = 300 # 5 minutes
_BASE_RESOLVED = str(BASE.resolve()) _BASE_RESOLVED = str(BASE.resolve())
@@ -88,13 +94,65 @@ def browse(path: str = ""):
return {"path": str(target.relative_to(BASE)), "entries": entries} return {"path": str(target.relative_to(BASE)), "entries": entries}
@router.get("/download") @router.post("/download-token")
def download(path: str): def create_download_token(path: str):
"""Generate a temporary download token for large file downloads."""
try: try:
target = _safe_path(path) target = _safe_path(path)
if not target.exists(): if not target.exists():
raise HTTPException(status_code=404, detail="File not found") raise HTTPException(status_code=404, detail="File not found")
return FileResponse(target)
# Clean up expired tokens
now = time.time()
expired = [t for t, (_, exp) in _download_tokens.items() if exp < now]
for t in expired:
del _download_tokens[t]
# Generate new token
token = secrets.token_urlsafe(32)
_download_tokens[token] = (str(target), now + TOKEN_EXPIRY)
return {"token": token, "expires_in": TOKEN_EXPIRY}
except ValueError:
raise HTTPException(status_code=403, detail="Access denied")
@router.get("/download")
def download(path: str = None, token: str = Query(None)):
"""Download a file. Supports both authenticated access (path param) and token-based access (token param)."""
try:
if token:
# Token-based download (no auth required)
if token not in _download_tokens:
raise HTTPException(status_code=403, detail="Invalid or expired token")
file_path, expiry = _download_tokens[token]
if time.time() > expiry:
del _download_tokens[token]
raise HTTPException(status_code=403, detail="Token expired")
# Consume token after use
del _download_tokens[token]
target = Path(file_path)
else:
# Authenticated download
if not path:
raise HTTPException(status_code=400, detail="Path or token required")
target = _safe_path(path)
if not target.exists():
raise HTTPException(status_code=404, detail="File not found")
def file_iterator():
with open(target, "rb") as f:
while chunk := f.read(8192 * 1024): # 8MB chunks
yield chunk
return StreamingResponse(
file_iterator(),
media_type="application/octet-stream",
headers={"Content-Disposition": f'attachment; filename="{target.name}"'}
)
except ValueError: except ValueError:
raise HTTPException(status_code=403, detail="Access denied") raise HTTPException(status_code=403, detail="Access denied")
+18 -13
View File
@@ -202,20 +202,25 @@ export async function download(path, filename) {
const headers = {}; const headers = {};
if (token) headers["Authorization"] = `Bearer ${token}`; if (token) headers["Authorization"] = `Bearer ${token}`;
const r = await fetch(`${BASE}/files/download?path=${encodeURIComponent(path)}`, { try {
method: "GET", // Get a temporary download token
const tokenResponse = await fetch(`${BASE}/files/download-token?path=${encodeURIComponent(path)}`, {
method: "POST",
headers, headers,
}); });
if (!r.ok) throw new Error(`HTTP ${r.status}`); if (!tokenResponse.ok) {
const errorText = await tokenResponse.text();
const blob = await r.blob(); console.error(`Download token failed: ${tokenResponse.status} - ${errorText}`);
const url = window.URL.createObjectURL(blob); throw new Error(`Download failed: ${tokenResponse.status}`);
const a = document.createElement("a"); }
a.href = url;
a.download = filename; const { token: downloadToken } = await tokenResponse.json();
document.body.appendChild(a);
a.click(); // Navigate directly to download URL - browser handles streaming natively
window.URL.revokeObjectURL(url); window.location.href = `${BASE}/files/download?token=${downloadToken}`;
document.body.removeChild(a); } catch (e) {
console.error("Download error:", e);
throw e;
}
} }
+31 -1
View File
@@ -6,6 +6,8 @@
let currentPath = $state(""); let currentPath = $state("");
let loading = $state(true); let loading = $state(true);
let uploading = $state(false); let uploading = $state(false);
let downloading = $state(false);
let error = $state("");
let fileInput; let fileInput;
async function browse(path) { async function browse(path) {
@@ -31,7 +33,16 @@
async function handleDownload(name) { async function handleDownload(name) {
const path = currentPath ? `${currentPath}/${name}` : name; const path = currentPath ? `${currentPath}/${name}` : name;
downloading = true;
error = "";
try {
await download(path, name); await download(path, name);
} catch (e) {
error = `Failed to download "${name}": ${e.message}`;
console.error("Download failed:", e);
} finally {
downloading = false;
}
} }
async function handleUpload() { async function handleUpload() {
@@ -84,6 +95,23 @@
</div> </div>
</div> </div>
<!-- Error message -->
{#if error}
<div class="bg-rose-50 dark:bg-rose-900/20 border border-rose-200 dark:border-rose-800 rounded-lg px-4 py-3 flex items-start gap-3">
<svg class="w-5 h-5 text-rose-500 shrink-0 mt-0.5" fill="none" viewBox="0 0 24 24" stroke="currentColor" stroke-width="2">
<path stroke-linecap="round" stroke-linejoin="round" d="M12 8v4m0 4h.01M21 12a9 9 0 11-18 0 9 9 0 0118 0z" />
</svg>
<div class="flex-1">
<p class="text-sm text-rose-700 dark:text-rose-300">{error}</p>
</div>
<button onclick={() => error = ""} class="text-rose-400 hover:text-rose-600 transition-colors">
<svg class="w-4 h-4" fill="none" viewBox="0 0 24 24" stroke="currentColor" stroke-width="2">
<path stroke-linecap="round" stroke-linejoin="round" d="M6 18L18 6M6 6l12 12" />
</svg>
</button>
</div>
{/if}
<!-- Breadcrumbs --> <!-- Breadcrumbs -->
<div class="flex items-center gap-1 text-sm flex-wrap"> <div class="flex items-center gap-1 text-sm flex-wrap">
<button class="text-primary-600 hover:text-primary-700 font-medium transition-colors" onclick={() => browse("")}>volume1</button> <button class="text-primary-600 hover:text-primary-700 font-medium transition-colors" onclick={() => browse("")}>volume1</button>
@@ -137,7 +165,9 @@
<span class="text-xs text-surface-400 text-right">{e.is_dir ? "—" : formatSize(e.size)}</span> <span class="text-xs text-surface-400 text-right">{e.is_dir ? "—" : formatSize(e.size)}</span>
<div class="flex items-center justify-end gap-1 opacity-100 md:opacity-0 md:group-hover:opacity-100 transition-opacity"> <div class="flex items-center justify-end gap-1 opacity-100 md:opacity-0 md:group-hover:opacity-100 transition-opacity">
{#if !e.is_dir} {#if !e.is_dir}
<button onclick={() => handleDownload(e.name)} class="text-[11px] text-primary-500 hover:text-primary-700 font-medium transition-colors">DL</button> <button onclick={() => handleDownload(e.name)} class="text-[11px] text-primary-500 hover:text-primary-700 font-medium transition-colors disabled:opacity-50" disabled={downloading}>
{downloading ? "..." : "DL"}
</button>
{/if} {/if}
<button class="text-[11px] text-rose-400 hover:text-rose-600 font-medium transition-colors" onclick={() => remove(e.name)}>Del</button> <button class="text-[11px] text-rose-400 hover:text-rose-600 font-medium transition-colors" onclick={() => remove(e.name)}>Del</button>
</div> </div>