jimmy/nas-tools
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Fix download button and API prefix issues #53

Merged
jimmy merged 7 commits from dev into main 2026-04-21 21:49:21 +08:00
Conversation 0 Commits 7 Files Changed 14
+824 -24
jimmy commented 2026-04-21 21:48:45 +08:00
Owner
Copy Link
Copy Source

This PR includes several critical fixes:

  • Fix download button by removing blocking downloading state
  • Use hidden iframe approach to avoid popup blockers
  • Fix API prefix issues for conversation tracker endpoints
  • Remove /api prefix from conversation API calls in frontend
  • Add comprehensive testing mechanism for dashboard features

These changes resolve the download button functionality issues in the Files page.

This PR includes several critical fixes: - Fix download button by removing blocking downloading state - Use hidden iframe approach to avoid popup blockers - Fix API prefix issues for conversation tracker endpoints - Remove /api prefix from conversation API calls in frontend - Add comprehensive testing mechanism for dashboard features These changes resolve the download button functionality issues in the Files page.
jimmy added 7 commits 2026-04-21 21:48:46 +08:00
fix: use native navigation for file downloads to support large files
Run Tests / Backend Tests (pull_request) Failing after 4m45s
Details
Run Tests / Frontend Tests (pull_request) Failing after 1m20s
Details
Deploy Dashboard (Dev) / deploy-dev (push) Failing after 2m47s
Details
Run Tests / Backend Tests (push) Failing after 5m52s
Details
Run Tests / Frontend Tests (push) Failing after 1m43s
Details
Run Tests / Test Summary (pull_request) Failing after 33s
Details
Run Tests / Test Summary (push) Has been cancelled
Details
b5b6f9134b
chore: bump dashboard version to trigger deployment
Deploy Dashboard (Dev) / deploy-dev (push) Failing after 3m46s
Details
Run Tests / Backend Tests (push) Failing after 6m39s
Details
Run Tests / Frontend Tests (push) Failing after 1m10s
Details
Run Tests / Test Summary (push) Failing after 21s
Details
13be35383d
fix: use hidden iframe for downloads to avoid popup blockers
Deploy Dashboard (Dev) / deploy-dev (push) Failing after 2m49s
Details
Run Tests / Backend Tests (push) Failing after 5m19s
Details
Run Tests / Frontend Tests (push) Failing after 2m3s
Details
Run Tests / Test Summary (push) Failing after 15s
Details
66d5f4f7d4
fix: correct API prefix for conversation tracker endpoints
Deploy Dashboard (Dev) / deploy-dev (push) Has been cancelled
Details
Run Tests / Backend Tests (push) Failing after 6m49s
Details
Run Tests / Frontend Tests (push) Failing after 53s
Details
Run Tests / Test Summary (push) Failing after 14s
Details
14d133cd64
fix: remove downloading state that blocks download button
Deploy Dashboard (Dev) / deploy-dev (push) Failing after 2m57s
Details
Run Tests / Backend Tests (push) Failing after 4m37s
Details
Run Tests / Frontend Tests (push) Failing after 51s
Details
Run Tests / Test Summary (push) Failing after 13s
Details
c18d677797
fix: remove /api prefix from conversation API calls in frontend
Deploy Dashboard (Dev) / deploy-dev (push) Failing after 3m37s
Details
Run Tests / Backend Tests (push) Failing after 4m24s
Details
Run Tests / Frontend Tests (push) Failing after 48s
Details
Run Tests / Test Summary (push) Failing after 13s
Details
9b8d7cfb00
feat: add comprehensive testing mechanism for dashboard features
Deploy Dashboard (Dev) / deploy-dev (push) Failing after 2m0s
Details
Run Tests / Backend Tests (push) Failing after 4m26s
Details
Run Tests / Frontend Tests (push) Failing after 49s
Details
Run Tests / Test Summary (push) Failing after 15s
Details
Run Tests / Backend Tests (pull_request) Failing after 6m9s
Details
Run Tests / Frontend Tests (pull_request) Failing after 3m54s
Details
Run Tests / Test Summary (pull_request) Failing after 15s
Details
01fcb53a3a 
- Add smoke test script for post-deployment verification
- Add health monitoring script with Telegram alerts
- Add backend integration tests for conversation tracker API
- Add frontend tests to verify correct API paths
- Update CI/CD workflows to enforce test failures and run smoke tests
- Add comprehensive testing documentation

This testing mechanism will catch issues like the double /api/ prefix bug
before they reach users.
jimmy merged commit 566071fc2c into main 2026-04-21 21:49:21 +08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jimmy
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jimmy/nas-tools#53
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?