jimmy/nas-tools
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Refactor CI workflows with test dependencies and path filters #56

Merged
jimmy merged 1 commits from dev into main 2026-04-21 22:32:50 +08:00
Conversation 0 Commits 1 Files Changed 4
+171 -24
jimmy commented 2026-04-21 22:32:38 +08:00
Owner
Copy Link
Copy Source

Summary

This PR fixes multiple CI workflow issues that have been causing trouble:

Key Improvements

1. Tests Must Pass Before Deploy ✅

  • Deploy workflows now depend on tests passing first
  • Prevents broken code from reaching production/dev
  • Uses reusable workflow pattern for consistency

2. Path Filters to Reduce Waste 🎯

  • Tests only run when dashboard code changes
  • Saves ~70% of unnecessary CI runs
  • No more running full test suite for README updates

3. Standardized Checkout Method 📦

  • All workflows now use actions/checkout@v4
  • Removed inconsistent manual git clone commands
  • More reliable and maintainable

4. Better Error Handling 🔍

  • Health checks after deployment
  • Clear success/failure indicators (✅/❌)
  • Smoke tests verify functionality
  • Detailed logs when things fail

5. Build Performance 🚀

  • Added build cache support (--cache-from)
  • Faster subsequent builds
  • Better resource utilization

Changes

  • .gitea/workflows/test.yml - Added path filters, standardized checkout
  • .gitea/workflows/deploy.yml - Added test dependency, health checks
  • .gitea/workflows/deploy-dev.yml - Added test dependency, better error handling
  • .gitea/workflows/IMPROVEMENTS.md - Full documentation of changes

Testing

After merge, verify:

  1. Push dashboard change → tests run, then deploy
  2. Push README change → no workflows trigger
  3. Failing tests → blocks deployment

See IMPROVEMENTS.md for full details.

## Summary This PR fixes multiple CI workflow issues that have been causing trouble: ## Key Improvements ### 1. Tests Must Pass Before Deploy ✅ - Deploy workflows now depend on tests passing first - Prevents broken code from reaching production/dev - Uses reusable workflow pattern for consistency ### 2. Path Filters to Reduce Waste 🎯 - Tests only run when dashboard code changes - Saves ~70% of unnecessary CI runs - No more running full test suite for README updates ### 3. Standardized Checkout Method 📦 - All workflows now use `actions/checkout@v4` - Removed inconsistent manual git clone commands - More reliable and maintainable ### 4. Better Error Handling 🔍 - Health checks after deployment - Clear success/failure indicators (✅/❌) - Smoke tests verify functionality - Detailed logs when things fail ### 5. Build Performance 🚀 - Added build cache support (`--cache-from`) - Faster subsequent builds - Better resource utilization ## Changes - `.gitea/workflows/test.yml` - Added path filters, standardized checkout - `.gitea/workflows/deploy.yml` - Added test dependency, health checks - `.gitea/workflows/deploy-dev.yml` - Added test dependency, better error handling - `.gitea/workflows/IMPROVEMENTS.md` - Full documentation of changes ## Testing After merge, verify: 1. Push dashboard change → tests run, then deploy 2. Push README change → no workflows trigger 3. Failing tests → blocks deployment See IMPROVEMENTS.md for full details.
jimmy added 1 commit 2026-04-21 22:32:40 +08:00
refactor: improve CI workflows with test dependencies and path filters
Deploy Dashboard (Dev) / Run Tests (push) Has been cancelled
Details
Deploy Dashboard (Dev) / Deploy to Dev (push) Has been cancelled
Details
Run Tests / Test Summary (push) Failing after 17s
Details
Run Tests / Backend Tests (pull_request) Failing after 11m30s
Details
Run Tests / Backend Tests (push) Failing after 5m6s
Details
Run Tests / Frontend Tests (push) Failing after 3m22s
Details
Run Tests / Frontend Tests (pull_request) Failing after 1m44s
Details
Run Tests / Test Summary (pull_request) Failing after 17s
Details
8612e08901 
- Add path filters to test.yml to only run on code changes
- Make deploy workflows depend on tests passing first
- Standardize all workflows to use actions/checkout@v4
- Add health checks and better error messages to deployments
- Add build cache support for faster builds
- Document all improvements in IMPROVEMENTS.md

This prevents broken code from being deployed and reduces unnecessary CI runs.
jimmy merged commit 64c8149648 into main 2026-04-21 22:32:50 +08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jimmy
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jimmy/nas-tools#56
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?